Skip to content

Prepare coordinated review workflow pin to verified merge commit - #6

Merged
AppSolves merged 1 commit into
mainfrom
chore/review-workflow-pin-4ed6688
Nov 14, 2026
Merged

AppSolves merged 1 commit into
mainfrom
chore/review-workflow-pin-4ed6688

Conversation

@AppSolves

Copy link
Copy Markdown
Owner

Prepares TRUSTED_WORKFLOW for the actual reviewed merge commit 4ed6688 from #5. No guessed SHA, dynamic ref, credential change or merge authorization change. Wrangler dry-run passes.

Do not merge/deploy this pin independently. The coordinated repository caller PR still requires an independent human review under its existing protected-branch rules. Keep the existing production pins until that approval is available; never use an administrator bypass to complete this rollout.

Once both sides are ready:

  1. Drain active reviews and apply additive migration 0003 with the pinned local Wrangler: node node_modules/wrangler/bin/wrangler.js d1 migrations apply codexbot --remote.
  2. Deploy the reviewed Worker with this exact TRUSTED_WORKFLOW value and merge the coordinated caller through its normal protections. Preserve existing secrets/bindings/OAuth gate and MERGE_DEPLOYMENT_AUTHORIZED=false. The short cross-service mismatch fails closed.
  3. Read back both live pins and compare exactly. Run the protected-default-branch administrator credential-only workflow to verify named Environment grants and signed OIDC without session access or inference.
  4. Separately authorize a new advisory/no-merge review for provider/broker/progress acceptance. Do not rerun the old request or infer OAuth success from synthetic SSE.

See docs/review-rollout.md. Source validation: 124 tests, typecheck/lint/build, clean-checkout, workerd/D1, Docker/sandbox, actionlint, dependency/image/source-secret scans and GitHub CI passed. Cache benchmark 14s ordinary / 49s cold / 14s restored: cache stays off. No remote migration/deployment or real provider inference has been performed for this change.

@AppSolves
AppSolves marked this pull request as ready for review November 14, 2026 13:43
@AppSolves
AppSolves merged commit acb94af into main Nov 14, 2026
4 checks passed
@AppSolves
AppSolves deleted the chore/review-workflow-pin-4ed6688 branch November 14, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant